On Wed, 29 Oct 2014, Damien Lespiau <damien.lespiau@xxxxxxxxx> wrote:
> As Paulo said when introducing the enum, having more types is really
> good to document what should go where (int foo(int, int, bool, bool).
>
> Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> Signed-off-by: Damien Lespiau <damien.lespiau@xxxxxxxxx>
Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> drivers/gpu/drm/i915/intel_drv.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 92f0005..efc3b82 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -408,7 +408,7 @@ static void vlv_clock(int refclk, intel_clock_t *clock)
> /**
> * Returns whether any output on the specified pipe is of the specified type
> */
> -bool intel_pipe_has_type(struct intel_crtc *crtc, int type)
> +bool intel_pipe_has_type(struct intel_crtc *crtc, enum intel_output_type type)
> {
> struct drm_device *dev = crtc->base.dev;
> struct intel_encoder *encoder;
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index d53ac23..f9adf3c 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -880,7 +880,7 @@ int intel_get_pipe_from_crtc_id(struct drm_device *dev, void *data,
> struct drm_file *file_priv);
> enum transcoder intel_pipe_to_cpu_transcoder(struct drm_i915_private *dev_priv,
> enum pipe pipe);
> -bool intel_pipe_has_type(struct intel_crtc *crtc, int type);
> +bool intel_pipe_has_type(struct intel_crtc *crtc, enum intel_output_type type);
> static inline void
> intel_wait_for_vblank(struct drm_device *dev, int pipe)
> {
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
