On Tue, 2014-10-28 at 16:15 +0200, ville.syrjala@xxxxxxxxxxxxxxx wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> The pps timestamp initialization was accidentally lost on vlv/chv in
>
> commit a4a5d2f8a96e09844a91469e889f15bd5e927399
> Author: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Date: Thu Sep 4 14:54:20 2014 +0300
>
> drm/i915: Track which port is using which pipe's power sequencer
>
> Restore it so that we avoid introducing random delays into the pps operations
> during/after driver init time.
>
> Cc: Imre Deak <imre.deak@xxxxxxxxx>
> Reported-by: Imre Deak <imre.deak@xxxxxxxxx>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Both patches look good to me:
Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 82e47da..25fe260 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5383,12 +5383,11 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port,
>
> if (is_edp(intel_dp)) {
> pps_lock(intel_dp);
> - if (IS_VALLEYVIEW(dev)) {
> + intel_dp_init_panel_power_timestamps(intel_dp);
> + if (IS_VALLEYVIEW(dev))
> vlv_initial_power_sequencer_setup(intel_dp);
> - } else {
> - intel_dp_init_panel_power_timestamps(intel_dp);
> + else
> intel_dp_init_panel_power_sequencer(dev, intel_dp);
> - }
> pps_unlock(intel_dp);
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
