On Mon, Oct 20, 2014 at 01:29:59PM +0000, Daniel, Thomas wrote: > > -----Original Message----- > > From: Chris Wilson [mailto:chris@xxxxxxxxxxxxxxxxxx] > > Sent: Monday, October 20, 2014 2:11 PM > > To: Daniel, Thomas > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; shuang.he@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH] drm/i915/bdw: Clean up execlist queue > > items in retire_work > > > > On Mon, Oct 20, 2014 at 02:05:55PM +0100, Thomas Daniel wrote: > > > No longer create a work item to clean each execlist queue item. > > > Instead, move retired execlist requests to a queue and clean up the > > > items during retire_requests. > > > > > > v2: Fix legacy ring path broken during overzealous cleanup > > > > At some point I presume you noticed that you broke the idle detection... > This patch doesn't change the idle detection. Did you want the idle flag to > now take into account the state of the execlists requests as well? I guess what Chris means is that execlist broke idle detection (by retiring in a separate work item, but not integrating with the idle handling in the existing one). This patch gets us half-way there but still doesn't really integrate things back fully. We probably need (again) the s/execlist_item/request/ refactor to make this happen for real. Since that's what Chris' patch does he featured the link to it as an endpoint guideline I think. Or am I completely missing the point again? Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
