On Fri, Oct 24, 2014 at 10:48:43AM +0200, Daniel Vetter wrote: > On Fri, Oct 24, 2014 at 08:30:56AM +0000, Daniel, Thomas wrote: > > > > > > > -----Original Message----- > > > From: Daniel Vetter [mailto:daniel.vetter@xxxxxxxx] On Behalf Of Daniel > > > Vetter > > > Sent: Friday, October 24, 2014 9:15 AM > > > To: Daniel, Thomas > > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; shuang.he@xxxxxxxxxxxxxxx > > > Subject: Re: [PATCH 2/2] drm/i915/bdw: Setup global hardware > > > status page in execlists mode > > > So every time a random new contexts gets created we write a new value into > > > the HWS_PGA register? Shouldn't this only be done when we set up the > > > default/system context? > > The write is inside an if(ctx == ring->default_ctx) block. > > We only write when the default context is created. > > Hm right, confusing diff context. And I guess we can't move that out to > logical_ring_init since it must happen before we init the render ring? > > I think extracting this entire block into a setup_global_hws or so helper > function would be useful for clarity. For reference, you can look at http://patchwork.freedesktop.org/patch/33175/ -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
