Re: [PATCH 1/4] drm/i915 Update Gen8 golden context batch buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 23, 2014 at 08:34:27AM -0700, armin.c.reese@xxxxxxxxx wrote:
> From: Armin Reese <armin.c.reese@xxxxxxxxx>
> 
> The file drivers/gpu/drm/i915/intel_renderstate_gen8.c is
> updated to the version created by IGT null_state_gen
> 
> Signed-off-by: Armin Reese <armin.c.reese@xxxxxxxxx>

For the first 3 patches:

Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx>

For the last patch, I'm really not convinced about reusing
i915_context_status(), I'd re-use i915_dump_lrc() instead. The reason is
that _status() seems to be about having a short summary of all context
images around, while dump_lrc() dumps content (only one page for now,
but that could be changed).

Also why the drm_clflush_pages()? CPU shouldn't access those pages past
the initial init.

-- 
Damien

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux