On Wed, Oct 22, 2014 at 07:11:21AM +0000, Cheng, Yao wrote: > > -----Original Message----- > > From: Daniel Vetter [mailto:daniel.vetter@xxxxxxxx] On Behalf Of Daniel > > Vetter > > Sent: Tuesday, October 21, 2014 8:09 PM > > To: Cheng, Yao > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Kelley, > > Sean V; Vetter, Daniel; Abel, Michael J; Jiang, Fei; Rao, Ram R > > Subject: Re: [RFC PATCH v2 1/4] drm/i915: add i915_ved.c to setup > > bridge for VED > > > > On Tue, Oct 21, 2014 at 02:36:41PM +0800, Yao Cheng wrote: > > > Setup minimum required resources during i915_driver_load: > > > 1. Create a platform device to share MMIO/IRQ resources 2. Make the > > > platform device child of i915 device for runtime PM. > > > 3. Create IRQ chip to forward the VED irqs. > > > VED driver (a standalone drm driver) probes the VED device and creates > > > a new dri card on install. > > > > > > Currently only supports VED on valleyview. > > > Kerneldoc is updated for i915_ved.c. > > > > > > Signed-off-by: Yao Cheng <yao.cheng@xxxxxxxxx> > > > > Please resend with a patch changelog to account for my review comments. > > And Ville's. Plus cc us both. And if there's anything you didn't address, you > > must reply to the review and we need to further discuss this. > > > > Daniel, I see, thanks for the instruction. > Do you mean resending the [RFC PATCH v2] with changelog and cc list? > Or adding changelog/cc when sending [RFC PATCH v3]? I think you could just add the per-patch changelog for both v2 and v3 when sending out v3. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
