On Mon, Oct 20, 2014 at 05:34:11PM +0200, Daniel Vetter wrote: > On Mon, Oct 20, 2014 at 05:31:51PM +0200, Daniel Vetter wrote: > > On Mon, Oct 20, 2014 at 04:37:15PM +1000, Dave Airlie wrote: > > > From: Dave Airlie <airlied@xxxxxxxxxx> > > > > > > This takes the tiling info from the connector and > > > exposes it to userspace, as a blob object in a > > > connector property. > > > > > > The contents of the blob is ABI. > > > > > > Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx> > > > --- > > > drivers/gpu/drm/drm_crtc.c | 36 ++++++++++++++++++++++++++++++++++++ > > > drivers/gpu/drm/i915/intel_dp_mst.c | 2 ++ > > > include/drm/drm_crtc.h | 4 ++++ > > > 3 files changed, 42 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > > > index 93135d4..81e867a 100644 > > > --- a/drivers/gpu/drm/drm_crtc.c > > > +++ b/drivers/gpu/drm/drm_crtc.c > > > @@ -1319,6 +1319,11 @@ static int drm_mode_create_standard_connector_properties(struct drm_device *dev) > > > "PATH", 0); > > > dev->mode_config.path_property = dev_path; > > > > > > + dev->mode_config.tile_property = drm_property_create(dev, > > > + DRM_MODE_PROP_BLOB | > > > + DRM_MODE_PROP_IMMUTABLE, > > > + "TILE", 0); > > > + > > > return 0; > > > } > > > > > > @@ -4004,6 +4009,37 @@ int drm_mode_connector_set_path_property(struct drm_connector *connector, > > > } > > > EXPORT_SYMBOL(drm_mode_connector_set_path_property); > > > > > > +int drm_mode_connector_set_tile_property(struct drm_connector *connector) > > > > Same again, please add some kerneldoc for this function here. > > While at it, please also add the missing kerneldoc for the functions > you've already added for dp mst support. And the docbook xml table with all the properties we have should also be updated for both of them. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
