Re: [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16/10/14 15:33, Cheng, Yao wrote:
> Hi Emil,
> Sorry, what do you mean by "correctly aligned"? does it mean the paddings in this data structure?
> 
Afaict for compatibility reasons the struct size have to be "aligned"
(multiple of 8 bytes), or if you prefer - the struct is missing the
required padding :) I've only skimmed through the patch so it may be
that other structs are having this issue.

Cheers,
Emil

>> -----Original Message-----
>> From: Emil Velikov [mailto:emil.l.velikov@xxxxxxxxx]
>> Sent: Wednesday, October 15, 2014 5:24 PM
>> To: Cheng, Yao; intel-gfx@xxxxxxxxxxxxxxxxxxxxx
>> Cc: emil.l.velikov@xxxxxxxxx; Jiang, Fei; dri-devel@xxxxxxxxxxxxxxxxxxxxx;
>> Vetter, Daniel
>> Subject: Re: [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm driver
>>
>> Hi Yao,
>>
>> struct drm_ipvr_gem_userptr does not seem to be correctly aligned - is
>> that intentional ? Might be worth checking if anything else in
>> ipvr_drm.h and ipvr_bufmgr.h is in the same boat.
>>
>> Cheers,
>> Emil
>>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux