On Sun, Oct 19, 2014 at 2:25 PM, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Mon, Oct 06, 2014 at 03:15:06PM +0100, John.C.Harrison@xxxxxxxxx wrote: >> From: John Harrison <John.C.Harrison@xxxxxxxxx> > > Empty commit messages are a bit too thin. E.g. in this case this was an > oversight from > > commit c8725f3dc0911d4354315a65150aecd8b7d0d74a > Author: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Date: Mon Mar 17 12:21:55 2014 +0000 > > drm/i915: Do not call retire_requests from wait_for_rendering > > which means your patch here really should have Cc'ed patch author and > revierer (i.e. Chris & Brad) of the offending patch, too. To make things clear: Cc'ing people isn't to assign blame for every single mistake they do (we're all racking up impressive amounts of them anyway), but to give them a learning opportunity and the chance to improve. It is pretty much impossible to follow intel-gfx and read everything that's on here even for me, so if you don't cc people for even the most mundane and small things they'll miss the mail. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
