On Sun, Oct 19, 2014 at 2:48 PM, Daniel Vetter <daniel@xxxxxxxx> wrote: >> @@ -2605,9 +2603,8 @@ static void i915_gem_reset_ring_cleanup(struct drm_i915_private *dev_priv, >> } >> >> /* These may not have been flush before the reset, do so now */ >> - kfree(ring->preallocated_lazy_request); >> - ring->preallocated_lazy_request = NULL; >> - ring->outstanding_lazy_seqno = 0; >> + kfree(ring->outstanding_lazy_request); >> + ring->outstanding_lazy_request = NULL; > > Somewhat unrelated, but shouldn't we move to refcount even the ring->plr? > If we allocate it then the ring->plr pointer would hold the ref, then it > gets transferred to the request list. Actually this is 100% related to this patch, since it replaces the ol seqno with the ol request. Would be good to clarify this in the commit message, since this patch doesn't remove the logic around olr, but really just does the switch from seqno to request. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
