Re: [PATCH 00/89] Basic Skylake enabling (reviewers)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ville,

I've compiled the list of patches for which I finally have versions that
should fix your comments and still require your r-b tag. You're in luck!
there are also a few additional follow-up patches, some to address your
concerns and one to address a known issue I listed here.

On Thu, Sep 04, 2014 at 03:16:03PM +0100, Damien Lespiau wrote:
> 
> Known issues:
> 
>   - There a known limitation in the DDB allocation code. It doesn't
>     respect the minimal allocation of 8 blocks. When we're trying to
>     scannout two planes (not counting the cursor) that have widely
>     different data rates (1080p and 64x64), we'll under-allocate the
>     small plane and hit underuns.

This is addressed by:

  drm/i915/skl: Make sure to allocate mininum sizes in the DDB
  http://lists.freedesktop.org/archives/intel-gfx/2014-October/053713.html

There's also a series addresses some of the concerns on top of the
initial patches as they were big enough to need a diff IMHO. This series
is:

  [PATCH 0/8] SKL WM fixups
  http://lists.freedesktop.org/archives/intel-gfx/2014-October/053571.html

And finally a rework of the DDB flush logic:

  [PATCH 0/3] Rework of the WM flush (for the DDB allocation)
  http://lists.freedesktop.org/archives/intel-gfx/2014-October/053605.html

> Patches 43 to 52: Ville (WM)

Remaining here:
  - 45: there's a v4
  - 46: the +1/-1 is addresses in the "SKL WM fixups" series
  - 47: v11 of the patch + some fixes in the "SKL WM fixups" series
  - 48: v6
  - 49: no need for anything more I believe
  - 50: needs review
  - 52: I think it can go as is, we may to track the work you're
	mentioning in Jira, I have it on my TODO list too now, but
	rather low prioriy

> Patches 76 to 83: Ville (WM part2)

Remaining here:
  - 76: needs review, trivial
  - 78: addressed in the "Rework of the WM flush (for the DDB
    allocation)" series
  - 81: trivial
  - 82: debugfs file to display the state of the DDB allocation
  - 83: DDB state readout and cross-check (it already helped me catch a
       problem when doing the 'end exclusive' patches)

Thanks!

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux