On Wed, Oct 01, 2014 at 11:41:31AM +0200, Daniel Vetter wrote: > On Wed, Oct 01, 2014 at 10:37:38AM +0100, Chris Wilson wrote: > > On Wed, Oct 01, 2014 at 11:28:47AM +0200, Daniel Vetter wrote: > > > This seems to have been accidentally lost in > > > > > > commit be62acb4cce1389a28296852737e3917d9cc5b25 > > > Author: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx> > > > Date: Fri Aug 30 16:19:28 2013 +0300 > > > > > > drm/i915: ban badly behaving contexts > > > > > > Without this real gpu hangs only log output at info level, which gets > > > filtered away by piglit's testrunner. > > > > > > v2: Tune down to notice level. Note that we need to add drm/i915 so > > > that at least the automatic igt dmesg filtering still picks it up. > > > > > > v3: git add and lack of coffee don't mix well. > > > > > > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxx> > > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > > Cc: Kenneth Graunke <kenneth@xxxxxxxxxxxxx> > > > Reported-by: Kenneth Graunke <kenneth@xxxxxxxxxxxxx> > > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > > > > Hmm, in my igt hang tests, I don't use dev_priv->gpu_error.stop_rings as > > it is itself incompatible with the tests. This now causes those to fail > > with a WARN. > > In Mika's reset stats test we've set stop_rings after execbuf so that we > could submit fancy stuff like endless loops with batch-chaining while > still shutting up the kernel's output for real hangs. That doesn't work for me when I try hanging from one context and running normal coherency tests in another... > The nice benefit is that looking at stop_rings then gives you an easy way > to double-check from the test that it all worked out since it's getting > auto-cleared. A single global value when using multiple concurrent rendering contexts is not so nice. Plus the interface is a pita. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
