Re: [PATCH] Revert "drm/i915/bdw: BDW Software Turbo"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 29, 2014 at 08:48:53AM -0700, Jesse Barnes wrote:
> On Mon, 29 Sep 2014 15:11:51 +0200
> Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
> 
> > This reverts commit c76bb61a71083b2d90504cc6d0dda2047c5d63ca.
> > 
> > It's apparently too broken so that Rodrigo submitted a patch to add a
> > config option for it. Given that the design is also ... suboptimal and
> > that I've only merged this to get lead engineers and managers off my
> > back for one second let's just revert this.
> > 
> > /me puts on combat gear again
> > 
> > It was worth a shot ...
> 
> I thought we had a fix for the runtime PM issue this created?  And
> Rodrigo's fix is just a simple "only BDW needs this" patch, so I guess
> I don't see the big issue?
> 
> Or is there another bug you didn't mention in the s-o-b section you're
> worried about?

Rodrigo's patch seems to set the new sw_turbo module option to 0 by
default, everywhere. So I've figured given Chris' very clear Nack on the
original patch it's kinda past the point where I can still sugar-coat
things with a straight enough face.

Or maybe I've totally missing again what's going on.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux