On Tue, Sep 02, 2014 at 03:38:44PM +0300, Jani Nikula wrote:
> On Tue, 02 Sep 2014, ville.syrjala@xxxxxxxxxxxxxxx wrote:
> > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> >
> > If the GPU frequency isn't going to change don't spam dmesg with
> > debug messages about it.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> Oh yes please!
>
> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
Queued for -next-fixes, thanks for the patch.
-Daniel
>
>
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 78e39f8..9bc44f0 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -3488,17 +3488,18 @@ void valleyview_set_rps(struct drm_device *dev, u8 val)
> > WARN_ON(val > dev_priv->rps.max_freq_softlimit);
> > WARN_ON(val < dev_priv->rps.min_freq_softlimit);
> >
> > - DRM_DEBUG_DRIVER("GPU freq request from %d MHz (%u) to %d MHz (%u)\n",
> > - vlv_gpu_freq(dev_priv, dev_priv->rps.cur_freq),
> > - dev_priv->rps.cur_freq,
> > - vlv_gpu_freq(dev_priv, val), val);
> > -
> > if (WARN_ONCE(IS_CHERRYVIEW(dev) && (val & 1),
> > "Odd GPU freq value\n"))
> > val &= ~1;
> >
> > - if (val != dev_priv->rps.cur_freq)
> > + if (val != dev_priv->rps.cur_freq) {
> > + DRM_DEBUG_DRIVER("GPU freq request from %d MHz (%u) to %d MHz (%u)\n",
> > + vlv_gpu_freq(dev_priv, dev_priv->rps.cur_freq),
> > + dev_priv->rps.cur_freq,
> > + vlv_gpu_freq(dev_priv, val), val);
> > +
> > vlv_punit_write(dev_priv, PUNIT_REG_GPU_FREQ_REQ, val);
> > + }
> >
> > I915_WRITE(GEN6_PMINTRMSK, gen6_rps_pm_mask(dev_priv, val));
> >
> > --
> > 1.8.5.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
