Re: [PATCH] drm/i915: Do not leak pages when freeing userptr objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 26 Sep 2014, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Sep 26, 2014 at 03:05:22PM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
>> 
>> sg_alloc_table_from_pages() can build us a table with coalesced ranges which
>> means we need to iterate over pages and not sg table entries when releasing
>> page references.
>> 
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
>> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>> Cc: "Barbalho, Rafael" <rafael.barbalho@xxxxxxxxx>
>
> Oh that's fun. I blame Imre for the recent invention of for_each_sg_page()!
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

Pushed to drm-intel-fixes, with the unused struct scatterlist *sg
variable removed. Thanks for the patch, review, and testing.

BR,
Jani.


> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux