On Thu, Sep 18, 2014 at 01:52:15PM +0200, Daniel Vetter wrote: > On Thu, Sep 18, 2014 at 07:03:32AM +0100, Chris Wilson wrote: > > As we use WC updates of the PTE, we are responsible for notifying the > > hardware when to flush its TLBs. Do so after we zap all the PTEs before > > suspend (and the BIOS tries to read our GTT). > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82340 > > Tested-by: ming.yao@xxxxxxxxx > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > This fixes a regression from the (functional) revert > > drm/i915: Undo gtt scratch pte unmapping again > > It apparently blows up on some machines. This functionally reverts > > commit 828c79087cec61eaf4c76bb32c222fbe35ac3930 > Author: Ben Widawsky <benjamin.widawsky@xxxxxxxxx> > Date: Wed Oct 16 09:21:30 2013 -0700 > > drm/i915: Disable GGTT PTEs on GEN6+ suspend > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64841 > Reported-and-Tested-by: Brad Jackson <bjackson0971@xxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > Cc: Takashi Iwai <tiwai@xxxxxxx> > Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > Cc: Todd Previte <tprevite@xxxxxxxxx> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx> > > Cc: stable@xxxxxxxxxxxxxxx > Cc: Takashi Iwai <tiwai@xxxxxxx> > Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > Cc: Todd Previte <tprevite@xxxxxxxxx> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > When fixing regressions pls don't forget to cite the offending commit and > cc all relevant people. Jani, please amend the commit with the above when > merging. I disagree that is the regression it is fixing, it is just band-aids all the way down. This patch fixes a bug present in the earlier patch. > Aside: This means that the bios writes to various ranges in the gtt, so I > still think we need to insert ptes pointing at stolen, too. Otherwise > we've simply reduced the chances for this bug to destroy important > something I think. Yup, the BIOS touching hardware it no longer has exclusive access to is fundamentally broken. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
