On Wed, Sep 24, 2014 at 02:16:49PM +0530, Gaurav K Singh wrote: > Hi, > These set of patches build on top of the existing DSI Video mode support to > enable dual link MIPI panels with high resolutions. These patches have been > tested on a 25x16 panel and works well. Except for the first patch (which only has a trivial "this is prep work" sentence) all your patches lack a commit message. If you do mechanical and trivial changes all over the driver split up into a bunch of patches this is ok, but for everything else it makes reviewing your code really hard since the reviewer has no idea _why_ some change is done. So please give your patches some good commit messages, focusing specifically on why you change things like you do (and also e.g. why other approaches would be worse). Also, the subject/summary should be at most 50 chars (with a hard limit at 80 characters), lots of them are longer. So probably some of the details of what exactly a patch changes should also be moved into the commit message. See "2) Describe your changes" in Documentation/SubmittingPatches for a some good examples and explanations. Also my review BKM training has some material about what a good commit message should entail. Thanks, Daniel > > Regards > Gaurav > > Gaurav K Singh (9): > drm/i915: New functions added for enabling & disabling MIPI Port Ctrl > reg > drm/i915: MIPI Sequence to be sent to the DSI Controller based on the > port no from VBT > drm/i915: MIPI Port Ctrl related changes for dual link configuration > drm/i915: Pixel Clock and pixel overlap related changes for dual link > Configuration > drm/i915: SHUTDOWN & Turn ON packets to be sent for both MIPI Ports > in case of dual link Configuration > drm/i915: Dsipll clk to be enabled for DSI1 in case of dual link > configuration > drm/i915: MIPI Timings related changes for dual link Configuration > drm/i915: MIPI encoder disable related changes for dual link > Configuration > drm/i915: MIPI Encoder enable related changes for dual link > configuration > > drivers/gpu/drm/i915/i915_reg.h | 5 + > drivers/gpu/drm/i915/intel_bios.h | 3 +- > drivers/gpu/drm/i915/intel_dsi.c | 471 ++++++++++++++++++---------- > drivers/gpu/drm/i915/intel_dsi.h | 8 + > drivers/gpu/drm/i915/intel_dsi_cmd.c | 44 +-- > drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 25 ++ > drivers/gpu/drm/i915/intel_dsi_pll.c | 14 +- > 7 files changed, 382 insertions(+), 188 deletions(-) > > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
