On Wed, 17 Sep 2014, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: > This is wrong. > > A skl_enable_backlight must be created setting c8254 propperly without the > shift 16. Also maybe setting c8354h. Nope, this is all right for skl/spt, with the small exception that it'll need the equivalent of [1]. I'll post another version addressing Ville's comments. BR, Jani. [1] http://mid.gmane.org/87y4tzefmz.fsf@xxxxxxxxx > > > On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau <damien.lespiau@xxxxxxxxx> > wrote: > >> From: Satheeshakrishna M <satheeshakrishna.m@xxxxxxxxx> >> >> Extending the BDW backlight implementation to SKL. >> >> Signed-off-by: Satheeshakrishna M <satheeshakrishna.m@xxxxxxxxx> >> Signed-off-by: Damien Lespiau <damien.lespiau@xxxxxxxxx> >> --- >> drivers/gpu/drm/i915/intel_panel.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_panel.c >> b/drivers/gpu/drm/i915/intel_panel.c >> index 1878447..d69a3cb6 100644 >> --- a/drivers/gpu/drm/i915/intel_panel.c >> +++ b/drivers/gpu/drm/i915/intel_panel.c >> @@ -1317,7 +1317,7 @@ void intel_panel_init_backlight_funcs(struct >> drm_device *dev) >> { >> struct drm_i915_private *dev_priv = dev->dev_private; >> >> - if (IS_BROADWELL(dev)) { >> + if (IS_BROADWELL(dev) || (INTEL_INFO(dev)->gen >= 9)) { >> dev_priv->display.setup_backlight = bdw_setup_backlight; >> dev_priv->display.enable_backlight = bdw_enable_backlight; >> dev_priv->display.disable_backlight = >> pch_disable_backlight; >> -- >> 1.8.3.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx >> > > > > -- > Rodrigo Vivi > Blog: http://blog.vivi.eng.br > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
