Re: [PATCH] drm/i915: Fix SRC_COPY width on 830/845g

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 12 Sep 2014, Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
> On Fri, 12 Sep 2014, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
>> One small change I forgot to make in
>>
>> commit c4d69da167fa967749aeb70bc0e94a457e5d00c1
>> Author: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>> Date:   Mon Sep 8 14:25:41 2014 +0100
>>
>>     drm/i915: Evict CS TLBs between batches
>>
>> was to update the copy width for the compact BLT copy instruction.
>>
>> Reported-by: Thomas Richter <thor@xxxxxxxxxxxxxxxxx>
>> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>> Cc: Thomas Richter <thor@xxxxxxxxxxxxxxxxx>
>> Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
>> Cc: stable@xxxxxxxxxxxxxxx
>
> http://mid.gmane.org/54129ED3.8060105@xxxxxxxxxxxxxxxxx says
>
> Tested-by: Thomas Richter <thor@xxxxxxxxxxxxxxxxx>
>
> (Thomas, your mails have broken in-reply-to/references more often than
> not, breaking threading. Please check your setup.)

Pushed to drm-intel-fixes with Daniel's irc ack, thanks for the patch
and testing.

BR,
Jani.


>
>
>> ---
>>  drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> index d0156d6..45d70fd 100644
>> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> @@ -1386,7 +1386,7 @@ i830_emit_batchbuffer(struct i915_gem_request *rq,
>>  		 */
>>  		intel_ring_emit(ring, SRC_COPY_BLT_CMD | BLT_WRITE_RGBA);
>>  		intel_ring_emit(ring, BLT_DEPTH_32 | BLT_ROP_SRC_COPY | 4096);
>> -		intel_ring_emit(ring, DIV_ROUND_UP(len, 4096) << 16 | 1024);
>> +		intel_ring_emit(ring, DIV_ROUND_UP(len, 4096) << 16 | 4096);
>>  		intel_ring_emit(ring, cs_offset);
>>  		intel_ring_emit(ring, 4096);
>>  		intel_ring_emit(ring, offset);
>> -- 
>> 1.9.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> -- 
> Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux