On Thu, Sep 11, 2014 at 09:30:27AM -0700, Volkin, Bradley D wrote: > On Thu, Sep 11, 2014 at 01:49:07AM -0700, Chris Wilson wrote: > > vma->exec_entry = memset(&dummy_exec_entry, 0, sizeof(dummy_exec_entry); > > > > Then you can kill the additional if (entry) checks. > > Also, don't we need to set vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN ? Yes we do. I realised that and mentioned it to Mika on IRC right after sending :| All the more reason for using the dummy_exec_entry/shadow_exec_entry. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx