On Thu, Sep 04, 2014 at 02:56:09PM +0300, Jani Nikula wrote: > BDW is always in the PCH override mode, and the bit MBZ. BSpec doesn't seem to agree. In fact it says the override must be enabled on bdw. > > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_panel.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c > index 18784470a760..066a66165cf1 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -780,9 +780,6 @@ static void bdw_enable_backlight(struct intel_connector *connector) > if (panel->backlight.active_low_pwm) > pch_ctl1 |= BLM_PCH_POLARITY; > > - /* BDW always uses the pch pwm controls. */ > - pch_ctl1 |= BLM_PCH_OVERRIDE_ENABLE; > - > I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1); > POSTING_READ(BLC_PWM_PCH_CTL1); > I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1 | BLM_PCH_PWM_ENABLE); > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx