Re: [PATCH 2/5] drm/i915/dp: Cache EDID for a detection cycle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 02 Sep 2014, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> @@ -3819,27 +3819,55 @@ intel_dp_get_edid(struct drm_connector *connector, struct i2c_adapter *adapter)
>  			return NULL;
>  
>  		return drm_edid_duplicate(intel_connector->edid);
> -	}
> +	} else
> +		return drm_get_edid(&intel_connector->base,
> +				    &intel_dp->aux.ddc);

Nitpick, I'd like to see braces on all branches if one branch requires
them. Also CodingStyle.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux