On Wed, Aug 27, 2014 at 05:48:41PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> During driver init we may not have a valid framebuffer for the primary
> plane even though the plane is enabled due to failed BIOS fb takeover.
> This means we have to avoid dereferencing the fb in
> .update_primary_plane() when disabling the plane.
>
> The introduction of the primary plane rotation in
>
> commit d91a2cb8e5104233c02bbde539bd4ee455ec12ac
> Author: Sonika Jindal <sonika.jindal@xxxxxxxxx>
> Date: Fri Aug 22 14:06:04 2014 +0530
>
> drm/i915: Add 180 degree primary plane rotation support
>
> caused a regression by trying to look up the pixel format before we can
> be sure there's a valid fb available. This isn't entirely unsurprising
> since the rotation patches originally predate the change to the primary
> plane code that calls .update_primary_plane() also when disabling the
> plane:
>
> commit fdd508a6419217cce28213f3c9bd27c02a0d4c71
> Author: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Date: Fri Aug 8 21:51:11 2014 +0300
>
> drm/i915: Call .update_primary_plane in intel_{enable,
> disable}_primary_hw_plane()
>
> v2: Warn but don't blow up when trying to enable a plane w/o an fb (Chris)
>
> Cc: Sonika Jindal <sonika.jindal@xxxxxxxxx>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
