On Tue, Aug 26, 2014 at 8:38 PM, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: > On Tue, Aug 26, 2014 at 12:54 AM, Daniel Vetter <daniel@xxxxxxxx> wrote: >> On Tue, Aug 26, 2014 at 2:39 AM, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> >> wrote: >> > So I prefer to continue using the HW/ring version we have already >> > working >> > for HSW and merge this v3 to get FBC working at BDW. >> >> Well for that we first need to fix up the psr testcase. I really want >> that. > > fbc and psr are independend features and tasks prioritization should come > from managers and program managers, right?! > >> And then I also want fbc enabled by default, which means you need to >> rebase/review Ville's patch series to make that work. > > We have FBC working with issues and protected by parameter on all platforms. > On BDW there is no fbc at all. This patch makes FBC state at least go to the > same level as we already have FBC working on all other platforms. > > I don't see a dependency here between this fix and the big FBC rework-fix. > This patch isn't enabling FBC by default. But allowing people that want and > need to use FBC. It's going to be the same answer for both parts - I don't really like if we add features but don't complete them (so testcases and enabled by default). And in our long meeting today a lot of people asked my why I'm reluctant to merge patches so that we can clean them up in-tree (which I agree is often the much more efficient approach). Reactions like yours here are pretty much the reason for that - getting something in to make an internal customer happy or check of a box in our tracking or some other requirement and then move on right away. And I know that you yourself are in a very bad spot trenched between me and requests from management and project tracking. And this is also not to single out you at all, it's just what I see all over. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
