On Thu, Aug 14, 2014 at 01:18:46PM +0300, Mika Kuoppala wrote: > Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes: > > > On Wed, Aug 13, 2014 at 05:50:38PM +0300, Mika Kuoppala wrote: > >> Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes: > >> > >> > The current error state harks back to the era of just a single VM. For > >> > full-ppgtt, we capture every bo on every VM. It behoves us to then print > >> > every bo for every VM, which we currently fail to do and so miss vital > >> > information in the error state. > >> > > >> > v2: Use the vma address rather than -1! > >> > > >> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > >> > >> Offsets can collide between different vm areas. > >> > >> If we add vm index also to the captured batchbuffer objects, > >> we could print it part of the offset '%d:0x%x' that would easily > >> identify vm and we would immediately see what vm was active on a ring. > > > > The offsets are printed out per-vm. You want to be more specific in your > > complaint. Based on earlier discussion, I think you just want to know > > the guilty vm. > > -Chris > > Yes. And it can be done as a follow up too. > > 1/5: > Reviewed-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxx> Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
