On 8/5/2014 6:00 PM, Daniel Vetter wrote:
On Tue, Aug 5, 2014 at 1:33 PM, Jindal, Sonika <sonika.jindal@xxxxxxxxx> wrote:
On 8/5/2014 4:45 PM, Daniel Vetter wrote:
On Tue, Aug 05, 2014 at 04:38:17PM +0530, sonika.jindal@xxxxxxxxx wrote:
From: Sonika Jindal <sonika.jindal@xxxxxxxxx>
Renaming defines to have levels instead of nominal values.
Signed-off-by: Sonika Jindal <sonika.jindal@xxxxxxxxx>
You can't split up patches like this since this will break compilation.
For larger stuff (and imo this is right above the cutoff) you first need
to add the new functions/defines, then convert everyone over. And only
when all the drivers are converted can we apply the patch to remove the
old functions/defines.
-Daniel
Got your concern. So, I will repost the first patch keeping both the defines
and an additional last patch for removing the extra defines.
Yeah. Btw for the actual replacement I highly recommend to do it with
a semantic patch and cocci. There's unfortunately not a hole lot of
good documentation around, but we recently started and it helps a lot
with regenerating patches (e.g. for newly merged drm drivers) and
avoiding mistakes for manual conversions. If we do a cocci patch we
put it into the commit message, grep for @@.
-Daniel
I need to find out about cocci. Can we go ahead with this patch series only?
-Sonika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
