On Tue, Aug 5, 2014 at 1:38 PM, Popov, Pavel E <pavel.e.popov@xxxxxxxxx> wrote: >> We have tons of places which use gem_aperture_size. Have you reviewed them all? > I've already looked at these places in latest trunk. I observed that type overflow also can happen in tests gem_evict_alignment and gem_evict_everything. But for our needs we only ported intel-gpu-tools 1.3 which doesn't contain these tests and I cannot check them on our configuration. At the moment we use 4GB for aperture size for our driver and observed that only gem_stress doesn't work correctly. We caught the bug after this test was fixed. Thanks for this test! Uhg, i-g-t 1.3 is rather old ... Can you try to roll forward your copy of i-g-t (_highly_ recommneded to stay at current code for validation, or at least always the latest release) and look at the other places? Unfortunately I don't know of any gcc tricks to make sure there's no integer precision truncation, so we have to rely on testing and review :( -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
