Re: [PATCH i-g-t 8/8] lib: add a command line option to enable debug output in tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



See my comment on patch 6.  --debug returns 'd' from getopt, which can conflict
with the short options for some tests, such as gem_render_copy and gem_seqn0_wrap.
This problem also exists for the --run-subtest.

  Tim

> -----Original Message-----
> From: Thomas Wood [mailto:thomas.wood@xxxxxxxxx]
> Sent: Wednesday, July 23, 2014 11:58 AM
> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Gore, Tim; daniel.vetter@xxxxxxxx
> Subject: [PATCH i-g-t 8/8] lib: add a command line option to enable debug
> output in tests
> 
> Add --debug as a common command line option for all tests to enable debug
> output.
> 
> Signed-off-by: Thomas Wood <thomas.wood@xxxxxxxxx>
> ---
>  lib/igt_core.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/igt_core.c b/lib/igt_core.c index 42b22fc..d90e6bb 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -276,7 +276,9 @@ static void print_usage(const char *command_str,
> const char *help_str,
> 
>  	fprintf(f, "Usage: %s [OPTIONS]\n"
>  		   "  --list-subtests\n"
> -		   "  --run-subtest <pattern>\n", command_str);
> +		   "  --run-subtest <pattern>\n"
> +		   "  --debug\n"
> +		   "  --help\n", command_str);
>  	if (help_str)
>  		fprintf(f, "%s\n", help_str);
>  }
> @@ -301,6 +303,7 @@ static int common_init(int argc, char **argv,
>  	static struct option long_options[] = {
>  		{"list-subtests", 0, 0, 'l'},
>  		{"run-subtest", 1, 0, 'r'},
> +		{"debug", 0, 0, 'd'},
>  		{"help", 0, 0, 'h'},
>  	};
>  	const char *command_str;
> @@ -349,6 +352,9 @@ static int common_init(int argc, char **argv,
>  	while ((c = getopt_long(argc, argv, short_opts, combined_opts,
>  			       &option_index)) != -1) {
>  		switch(c) {
> +		case 'd':
> +			igt_log_level = IGT_LOG_DEBUG;
> +			break;
>  		case 'l':
>  			if (!run_single_subtest)
>  				list_subtests = true;
> --
> 1.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux