You mean you prefer the the loop with for (i = 0; i < hweight(ring_mask); i++) { instead? I thought you were ok with either and I preferred this one just to be on the safest side and let userspace parse it properly. Or do you prefer that other version with double loop but with names of rings? Thanks, Rodrigo. -----Original Message----- From: Widawsky, Benjamin Sent: Thursday, July 17, 2014 5:23 PM To: Vivi, Rodrigo Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH] drm/i915: print full error ring semaphore mboxes and sync. On Thu, Jul 17, 2014 at 09:39:55AM -0700, Rodrigo Vivi wrote: > With the increasing number of rings, > we probably have more information to print than we were printing. After our discussion were you going to send a new patch? [snip] -- Ben Widawsky, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx