On Mon, Jul 14, 2014 at 04:22:44AM +0000, Sun, Daisy wrote: > 3) The function will be called when flip happened, this should cover > most of the cases. One exception is background media process without any > display output, it's relatively rare. Please let me know if you have > concern on other cases, I will try to cover it definitely. Traditional X never flips. And we kinda have to keep this working. Instead of checking when flipping we need to check at regular time intervals I guess, for as long as the gt is busy. -Daniel > > > -----Original Message----- > From: Chris Wilson [mailto:chris@xxxxxxxxxxxxxxxxxx] > Sent: Thursday, July 10, 2014 11:16 PM > To: Sun, Daisy > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v2] drm/i915/bdw: BDW Software Turbo > > On Thu, Jul 10, 2014 at 07:39:32PM -0700, Sun, Daisy wrote: > > > > This Software turbo will mainly take place of the hardware driven > > interrupt part without touching the boost/idle strategy. > > So gen6_rps_boost and gen6_rps_idle will still function for BDW. > > You still are not addressing that your function is either called at a random time, and more often than not, never. You also disabled the set_rps paths which would have disabled boost and idle. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
