On Wed, Jul 09, 2014 at 02:08:08PM +0100, Tvrtko Ursulin wrote: > > On 06/19/2014 12:13 PM, Damien Lespiau wrote: > >On Wed, Feb 26, 2014 at 04:41:41PM +0000, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > >> > >>Allow userptr objects to be created and used via libdrm_intel. > >> > >>At the moment tiling and mapping to GTT aperture is not supported > >>due hardware limitations across different generations and uncertainty > >>about its usefulness. > >> > >>Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > >>--- > >> include/drm/i915_drm.h | 16 +++++ > >> intel/intel_bufmgr.c | 13 ++++ > >> intel/intel_bufmgr.h | 5 ++ > >> intel/intel_bufmgr_gem.c | 154 +++++++++++++++++++++++++++++++++++++++++++++- > >> intel/intel_bufmgr_priv.h | 12 +++- > >> 5 files changed, 198 insertions(+), 2 deletions(-) > > > >Apart from couple of remarks below I couldn't find anything that would > >prevent merging this. Well, except maybe that it'd be very nice to have > >some feedback from someone using it, we do have an API/ABI guarantee on > >libdrm after all. > > Looks like I've forgotten to reply to this. I did address the other > review comments and sent out a v2 back then. > > But for what users are concerned, apart from internal ones who have > been using this API for some years now, I don't know of any. Well, considering this is only a wrapper of an ioctl() already upstreamed, I'm inclined to just push it as is. Daniel any thoughts? -- Damien _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
