> -----Original Message----- > From: Lespiau, Damien > Sent: Thursday, July 03, 2014 7:19 PM > To: Nikula, Jani > Cc: Lin, Mengdong; alsa-devel@xxxxxxxxxxxxxxxx; tiwai@xxxxxxx; > intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 1/2] drm/i915: provide interface for audio > driver to query cdclk > > On Thu, Jul 03, 2014 at 10:32:38AM +0300, Jani Nikula wrote: > > On Thu, 03 Jul 2014, mengdong.lin@xxxxxxxxx wrote: > > > From: Jani Nikula <jani.nikula@xxxxxxxxx> > > > > I wrote this as a quick hack patch to try as an alternative to [1] > > which ended up not working on Haswell. Please reassure me that this is > > going to be a temporary solution until we get a more generic interface > > between the audio and display drivers. I don't much like this, but at > > least it's isolated and small. > > > > I'd like the commit message amended with something like: > > > > """ > > If the display power well has been disabled, the display audio > > controller divider values EM4 MVALUE and EM5 NVALUE will have been > > lost. The CDCLK frequency is required for reprogramming them. Provide > > a private interface for the audio driver to query CDCLK. > > > > This is a stopgap solution until a more generic interface between > > audio and display drivers has been implemented. > > """ > > > > I'd also like to have an additional Reviewed-by from the i915 side. > > After that, I'm fine with merging this through alsa. > > Sure. > > Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx> > > -- > Damien Thank you, Jani and Damien! I'll add the comment message and submit the revised patch tomorrow. Regards Mengdong _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
