On Thu, Jun 19, 2014 at 12:07 PM, Damien Lespiau <damien.lespiau@xxxxxxxxx> wrote: > On Thu, Jun 19, 2014 at 01:22:25PM +0530, Jindal, Sonika wrote: >> >>I see that in omap driver too it is done in lastclose of the driver. Also, >> >>from driver fbdev_restore is only called during lastclose. >> >>Again I don't have more knowledge on this. >> >>Can we keep it here in this lastclose function to comply with omap driver? > > Just to be thorough, there's an important path that is not from > lastclose(): > > + drm_fb_helper_set_par() > + drm_fb_helper_restore_fbdev_mode_unlocked() > + restore_fbdev_mode() Yeah, that's the vt restore thing when leaving X/wayland. So we want want this in restore_fbdev_mode even just for i915 - fixing up other drivers is just a bit a bonus. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
