> -----Original Message----- > From: Chris Wilson [mailto:chris@xxxxxxxxxxxxxxxxxx] > Sent: Friday, June 13, 2014 5:51 PM > To: Mateo Lozano, Oscar > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 51/53] drm/i915/bdw: Document Logical > Rings, LR contexts and Execlists > > On Fri, Jun 13, 2014 at 04:38:09PM +0100, oscar.mateo@xxxxxxxxx wrote: > > +/** > > + * intel_execlists_ctx_id() - get the Execlists Context ID > > + * @ctx_obj: Logical Ring Context backing object. > > + * > > + * Do not confuse with ctx->id! Unfortunately we have a name overload > > + * here: the old context ID we pass to userspace as a handler so that > > + * they can refer to a context, and the new context ID we pass to the > > + * ELSP so that the GPU can inform us of the context status via > > + * interrupts. > > + * > > + * Return: 20-bits globally unique context ID. > > + */ > > Use tag for the ctx id we pass around in hw? > -Chris I also tried other names, like "submission id", but it confuses people when they search for in the BSpec. Maybe changing ctx->id to ctx->tag, and leaving id for the hardware? -- Oscar _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
