--------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47 > -----Original Message----- > From: Daniel Vetter [mailto:daniel.vetter@xxxxxxxx] On Behalf Of Daniel > Vetter > Sent: Friday, June 13, 2014 6:01 PM > To: Mateo Lozano, Oscar > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 02/53] drm/i915: Rename ctx->obj to ctx- > >render_obj > > On Fri, Jun 13, 2014 at 04:37:20PM +0100, oscar.mateo@xxxxxxxxx wrote: > > From: Oscar Mateo <oscar.mateo@xxxxxxxxx> > > > > The reason for doing this will be better explained in the following > > patch. For now, suffice it to say that this backing object is only > > used with the render ring, so we're making this fact more explicit. > > > > Done with the following Coccinelle patch (plus manual renaming of the > > struct field): > > > > @@ > > struct intel_context c; > > @@ > > - (c).obj > > + c.render_obj > > > > @@ > > struct intel_context *c; > > @@ > > - (c)->obj > > + c->render_obj > > > > Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx> > > Just screamed at this code reviewing a bugfix from Chris and I really like this. > Can we have a s/is_initialized/render_is_initialized/ on top pls? > > Or does that interfere too much with the series? I didn't look ahead ... > -Daniel No problem, I can add that on top without any hassle. I´ll send it together with a bunch of other prep-work patches. -- Oscar _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
