On Tue, Jun 10, 2014 at 02:47:29PM +0300, Ville Syrjälä wrote: > On Tue, Jun 10, 2014 at 12:33:48PM +0100, Chris Wilson wrote: > > On Tue, Jun 10, 2014 at 02:25:50PM +0300, Ville Syrjälä wrote: > > > On Tue, Jun 10, 2014 at 11:04:00AM +0100, Chris Wilson wrote: > > > > +static inline int crtc_sbc(struct intel_crtc *crtc) > > > > +{ > > > > + return atomic_read(&crtc->base.dev->vblank[crtc->pipe].count); > > > > +} > > > > > > Still says 'sbc' which doesn't make sense to me. > > > > I just don't like the term msc. :-p > > crtc_vblank_counter()? > > Maybe stick it into drmP.h and call it drm_crtc_vblank_counter() or > something? Hopefully people won't confuse it with the hardware counter. It's called drm_vblank_count, but a new wrapper which takes a drm_crtc * as the argument would indeed be nice. So drm_crtc_vblank_counter(struct drm_crtc *crtc). And please don't forget to add the kerneldoc and to pull it into the drm docbook. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx