Re: [PATCH 2/3] drm/i915: Change Mipi register definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 01, 2014 at 06:41:54AM +0100, Sharma, Shashank wrote:
> Hi Damien, 
> Please correct me if I am missing something, but the only reason we
> are seeing those extra formatting changes is, almost all of the old
> MIPI register definitions were beyond 80 char, and was checked in like
> that with warnings (How ?) So when I was checking for checkpatch
> errors, I saw that, and I tried to fix that in the previous patch. 

You're absolutely correct.

However that 80 chars limit is a soft one and I think, in that case,
being able to review the patch wins. Would someone think it's a good
idea to have those definitions under 80 chars, one could always send a
patch *just* changing that. I wouln't bother.

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux