On Thu, May 29, 2014 at 1:21 AM, Damien Lespiau <damien.lespiau@xxxxxxxxx> wrote: > On Thu, May 29, 2014 at 12:27:55AM +0200, Daniel Vetter wrote: >> - if (IS_HASWELL(dev) && intel_crtc->config.pch_pfit.enabled) >> + if (IS_HASWELL(dev) && intel_crtc->config.pch_pfit.enabled || >> + intel_crtc->config.pch_pfit.force_thru) >> temp |= TRANS_DDI_EDP_INPUT_A_ONOFF; > > My gcc warns here, suggesting the addition of (). And indeed, it seems > that we want: > > if (IS_HASWELL(dev) && (intel_crtc->config.pch_pfit.enabled || > intel_crtc->config.pch_pfit.force_thru)) > temp |= TRANS_DDI_EDP_INPUT_A_ONOFF; It doesn't actually matter since force_thru is set only on HSW. We can set them whereever we want, and I think actually wrapping it like (IS_HSW && pfit.enabled) || pfit.force_thru reads saner. Otoh only HSW has this peculiarity. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
