On Tue, May 27, 2014 at 06:26:22PM +0530, Shobhit Kumar wrote:
> It seems by default the VBT has MIPI configuration block as well. The
> Generic driver will assume always MIPI if MIPI configuration block is found.
> This is causing probelm when actually there is eDP. Fix this by looking
> into general definition block which will have device configurations. From here
> we can figure out what is the LFP type and initialize MIPI only if MIPI
> is found.
>
> v2: Addressed review comments by Damien
> - Moved PORT definitions to intel_bios.h and renamed as DVO_PORT_MIPIA
> - renamed is_mipi to has_mipi and moved definition as suggested
> - Check hs_mipi inside parse_mipi and intel_dsi_init insted of outside
>
> Signed-off-by: Shobhit Kumar <shobhit.kumar@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/intel_bios.c | 14 ++++++++++++++
> drivers/gpu/drm/i915/intel_bios.h | 4 ++++
> drivers/gpu/drm/i915/intel_dsi.c | 4 ++++
> 4 files changed, 24 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 8e78703..dac9ceb 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1209,6 +1209,7 @@ struct intel_vbt_data {
> unsigned int fdi_rx_polarity_inverted:1;
> int lvds_ssc_freq;
> unsigned int bios_lvds_val; /* initial [PCH_]LVDS reg val in VBIOS */
> + int has_mipi;
I meant this can be added in the bitfield (after
fdi_rx_polarity_inverted) so it only takes 1 bit
Otherwise:
Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx>
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
