On 5/27/2014 5:09 PM, Daniel Vetter wrote:
On Tue, May 27, 2014 at 04:51:55PM +0530, Kumar, Shobhit wrote:
On 5/27/2014 4:32 PM, Damien Lespiau wrote:
On Fri, May 23, 2014 at 09:35:27PM +0530, Shobhit Kumar wrote:
This driver makes use of the generic panel information from the VBT.
Panel information is classified into two - panel configuration and panel
power sequence which is unique to each panel. The generic driver uses the
panel configuration and sequence parsed from VBT block #52 and #53
v2: Address review comments by Jani
- Move all of the things in driver c file from header
- Make all functions static
- Make use of video/mipi_display.c instead of redefining
- Null checks during sequence execution
v3: Address review comments by Damien
- Rename the panel driver file as intel_dsi_panel_vbt.c
- Fix style changes as suggested
- Correct comments for lp->hs and hs->lp count calculations
- General updating comments to have more clarity
- using max() instead of ternary operator
- Fix names (ui_num, ui_den) while using UI in calculations
- compute max of lp_to_hs switch and hs_to_lp switch while computing
hs_lp_switch_count
Signed-off-by: Shobhit Kumar <shobhit.kumar@xxxxxxxxx>
Hopefully still works after all that :)
It does, at least on AsusT100 :) Thanks for the review
Aside: checkpatch.pl complained a bit about style issues in your patch
(like unpretty alignment of continuation lines and stuff like that).
Please feed your patches to checkpatch if you don't have an editor that
simply gets this right.
Hmm, I will check my vim config and be more careful next time. Thanks
for pointing out. Have you taken care of these or I will push another
patch to fix the alignment issues ?
Regards
Shobhit
-Daniel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
