On Wed, May 21, 2014 at 03:40:15PM +0000, Mateo Lozano, Oscar wrote: > > -----Original Message----- > > From: Mika Kuoppala [mailto:mika.kuoppala@xxxxxxxxxxxxxxx] > > Sent: Tuesday, May 20, 2014 12:56 PM > > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > Cc: Mateo Lozano, Oscar > > Subject: [PATCH 1/2] tests/drv_hangman: Convert test from shell script to c > > > > Mixing script and standlone tests didn't mix well with the strict i915_ring_stop > > flags handling. Also squash drv_missed_irq_hang to the new test. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78322 > > Suggested-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Signed-off-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxx> > > --- > > tests/Makefile.sources | 3 +- > > tests/drv_hangman | 70 --------- > > tests/drv_hangman.c | 357 > > +++++++++++++++++++++++++++++++++++++++++++++ > > tests/drv_missed_irq_hang | 70 --------- > > I am missing a tests/.gitignore entry > Other than that: Reviewed-by: Oscar Mateo <oscar.mateo@xxxxxxxxx> The nop batch isn't good enough to reliably provoke a stall for the gpu. Without that the missed irq test won't work. The script uses some pretty expensive blitter workload (gem_exec_blt). Since patch 1 fixes a regresssion I think we should just take out those subtests and keep the missed_irq script for now so that we can push this series. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
