On Wed, May 21, 2014 at 01:20:55PM +0200, Thierry Reding wrote: > On Wed, May 14, 2014 at 08:51:05PM +0200, Daniel Vetter wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > If there's a blocking vblank wait in progress while the vblank interrupt > > gets disabled, the current code will just let the vblank wait time out. > > Instead make it return immediately when vblank interrupts get disabled. > > Can this even happen? drm_wait_vblank() takes a vblank reference earlier > and drops it right before returning. But perhaps this will become > obvious since from a quick peek some of the subsequent patches seem like > they will make it possible to force VBLANK off? Ah, it seems like drm_vblank_off() can already do exactly that, in which case this makes sense: Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
pgpVlRtXuqVxN.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
