On Wed, May 14, 2014 at 08:51:04PM +0200, Daniel Vetter wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Currently there's one per-device vblank disable timer, and it gets > reset wheneven the vblank refcount for any crtc drops to zero. That "whenever" > means that one crtc could accidentally be keeping the vblank interrupts > for other crtcs enabled even if there are no users for them. Make the > disable timer per-crtc to avoid this issue. Very pedantically: s/crtc/CRTC/ and maybe even s/vblank/VBLANK/. Feel free to ignore those, though. =) Also, and I may have asked before, why do we even need this timer? Why not simply disable interrupts when the last vblank reference goes away? Generally, though: Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
pgpFGFCoBB3BU.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
