On Mon, May 19, 2014 at 04:45:26PM +0100, Damien Lespiau wrote: > On Mon, May 19, 2014 at 08:54:03PM +0530, Shashank Sharma wrote: > > This patch adds a mmio base address variable for DSI display, > > to make the DSI code generic, so that, if required, the same code > > can be re-used for future platforms with different mmio base. > > > > Signed-off-by: Shashank Sharma <shashank.sharma@xxxxxxxxx> > > The error message is really a programming error, ie if we hit this > error, the the code itself is doing something it shouldn't be doing. > > This is to be compared to an error caused by external factors. > > For that reason, I'd use BUG() here, but I'm not sure that's something > we've clearly defined. > > Also the error message is not super clear and uses Mipi instead of MIPI, > we always captalize it elsewhere. > > Depending on how much bikesheddy other peole are: You might want to add some checkpatch bikesheds, but I've fixed them up while applying. > > Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx> Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
