Thanks Damien for your review
On Thursday 15 May 2014 10:18 PM, Damien Lespiau wrote:
On Mon, Apr 14, 2014 at 11:18:27AM +0530, Shobhit Kumar wrote:
>This driver makes use of the generic panel information from the VBT.
>Panel information is classified into two - panel configuration and panel
>power sequence which is unique to each panel. The generic driver uses the
>panel configuration and sequence parsed from VBT block #52 and #53
>
>v2: Address review comments by Jani
> - Move all of the things in driver c file from header
> - Make all functions static
> - Make use of video/mipi_display.c instead of redefining
> - Null checks during sequence execution
>
>Signed-off-by: Shobhit Kumar<shobhit.kumar@xxxxxxxxx>
I've done a first past on this. Overall looks reasonable. I'm missing
some documentation to double check the various LP->HS, HS->LP count and
other magic around the clocks (send you a mail about it) before I can
add my r-b tag.
I've added a few tiny comments as well along the road.
All look okay to me and Will push updated patch asap.
There is one issue which I am struggling for now. If we have all these
patches in, then disable sequence pipe off does not work and
wait_for_pipe_off gives a warn dump but everything works. Its not this
patch issue but DSI patches that are already merged. I know the fix is
to actually disable port after disabling pipe and plane but doing that
does not succeed enable in first attempt. Subsequent disable/enable
works. Looking into that and should have a fix by next week on that.
Regards
Shobhit
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
