On Wed, May 14, 2014 at 08:34:03PM +0200, Daniel Vetter wrote: > On Wed, May 14, 2014 at 06:50:27PM +0100, Damien Lespiau wrote: > > On Wed, May 14, 2014 at 06:00:46PM +0200, Daniel Vetter wrote: > > > I want to use them elsewhere ... > > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > > --- > > > lib/igt_aux.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > lib/igt_aux.h | 11 ++++++ > > > tests/pm_pc8.c | 96 ++---------------------------------------------- > > > 3 files changed, 128 insertions(+), 93 deletions(-) > > > > Just a small thing, let's not abuse _aux.c to put random stuff. How about > > adding a new _pm.c? > > Well it's just three functions, the suspend helper is also already in > there and igt_aux is fairly small. We can split once it's too big. > > igt_aux is very much just the bin for everything that doesn't fit anywhere > else ;-) Yeah, I can't see a kitchen-sink file going wrong, that has never happened before :) -- Damien _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
