On Wed, May 14, 2014 at 08:05:11AM +0200, David Herrmann wrote: > Hi > > On Wed, May 14, 2014 at 2:03 AM, Dave Airlie <airlied@xxxxxxxxx> wrote: > > Since any objects you get with find are only valid under mode_config.mutex, > > yes some drivers mess this up, but they should be fixed. > > Didn't know that we have such a rule. Then it's fine, of course. The > page-flip code is what worried me, but drivers ought to cancel that > when destroying connectors, anyway. i915 cancels/stalls for any pageflips when we switch off the crtc, so I think we should be fine. And the above rule is for all modeset objects except framebuffers, since those are separately protected with refcounting and you don't even need the big mode_config mutex to do the idr lookup. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx