On Mon, 2014-04-28 at 15:35 -0300, Paulo Zanoni wrote: > 2014-04-28 15:22 GMT-03:00 Imre Deak <imre.deak@xxxxxxxxx>: > > On Mon, 2014-04-28 at 14:57 -0300, Paulo Zanoni wrote: > >> 2014-04-25 5:08 GMT-03:00 Daniel Vetter <daniel@xxxxxxxx>: > >> > On Fri, Apr 25, 2014 at 10:29:57AM +0300, Imre Deak wrote: > >> >> The PC8 state won't be entered unless runtime PM is enabled, so support > >> >> for PC8 residency counters alone is not enough to run this test. > >> > >> This is true only for the very latest kernels. We have Kernels with > >> PC8 support and without runtime PM support. Do you actually need this > >> specific patch to solve any problems you're currently having? If not, > >> maybe we could revert it so people with stable Kernels will be able to > >> run IGT. > > > > The following one needs this at least on BDW/current kernel: > > https://bugs.freedesktop.org/show_bug.cgi?id=77565 > > This is not a fix to the bug. By skipping the whole test suite, this > patch is just hiding the fact that PC8 doesn't work on BDW. Yes, PC8 > on BDW (specifically) won't work without runtime PM, but that's not > true for HSW on some Kernels. The proper fix to the bug above is to > fix RC6 on BDW, or revert the revert. Note that recently we made RC6 a requirement for runtime PM, so fixing it is the only option for re-enabling runtime PM. > > I might be wrong, but I thought we don't need backward compatibility in > > igt. We could also make the check kernel version dependent, I'm not sure > > if it's worth the effort. > > > > --Imre > > > >> > >> Thanks, > >> Paulo > >> > >> >> > >> >> Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> > >> > > >> > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > >> > > >> >> --- > >> >> tests/pm_pc8.c | 2 +- > >> >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> >> > >> >> diff --git a/tests/pm_pc8.c b/tests/pm_pc8.c > >> >> index 010af44..9a95326 100644 > >> >> --- a/tests/pm_pc8.c > >> >> +++ b/tests/pm_pc8.c > >> >> @@ -769,7 +769,7 @@ static void setup_environment(void) > >> >> printf("Runtime PM support: %d\n", has_runtime_pm); > >> >> printf("PC8 residency support: %d\n", has_pc8); > >> >> > >> >> - igt_require(has_runtime_pm || has_pc8); > >> >> + igt_require(has_runtime_pm); > >> >> } > >> >> > >> >> static void teardown_environment(void) > >> >> -- > >> >> 1.8.4 > >> >> > >> >> _______________________________________________ > >> >> Intel-gfx mailing list > >> >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > >> >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > >> > > >> > -- > >> > Daniel Vetter > >> > Software Engineer, Intel Corporation > >> > +41 (0) 79 365 57 48 - http://blog.ffwll.ch > >> > _______________________________________________ > >> > Intel-gfx mailing list > >> > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > >> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > >> > >> > >> > > > > > > > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
