On Fri, Apr 25, 2014 at 11:16 PM, Sun, Daisy <daisy.sun@xxxxxxxxx> wrote: > Thanks for the timely reply, Daniel. > > The intention to bring debugfs for RPS boost and idle is when boost and idle > are disabled, we are able to have a clear vision of what normal turbo > algorithm. > It‘s very helpful to verify if the turbo algorithm is working as expected, > at least from the VPG validation team. > > Without the debugfs hooks, the RPS boost or idle may kicks in at anytime and > any circumstances, which makes it complicated. > It does not mean RPS boost and idle is doing anything wrong, that's a > different story. A fixed frequency setting is useful in some other cases but > not enough to verify turbo algorithm. > > I'd like to add the purpose in commit msg if it's not clear. Yeah if this is useful for the hw validation team then a debugfs interface makes sense. But the patch must mention this motivation since if you try to use this in production to work around issues with the turbo booster then that's not good ;-) Please update the commit message with these important details and resubmit the patch. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
