On Tue, Apr 15, 2014 at 09:41:38PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > All of the .queue_flip() callbacks duplicate the same code to pin the > buffers and calculate the gtt_offset. Move that code to > intel_crtc_page_flip(). In order to do that we must also move the ring > selection logic there. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> I was a little uneasy about this given the fun-and-games we play with ring selection and the historic issues we have had with bugs in unpinning. However, this looks to be worth it, especially with the new piece of common code, Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
